Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): popover and selected issues #257

Merged
merged 2 commits into from
Sep 29, 2022
Merged

fix(select): popover and selected issues #257

merged 2 commits into from
Sep 29, 2022

Conversation

mustafafrw
Copy link
Contributor

@mustafafrw mustafafrw commented Sep 29, 2022

  • As mentioned in this issue#252 there is a bug in _closeOutsideHandler function.
  • I realized another bug when multiple = false. It is not appearing in the selected state when an option is selected.
  • Also, event listeners moved into open and close functions

Fixes #252

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👏🏻

@muratcorlu muratcorlu merged commit 4cd7d67 into next Sep 29, 2022
@muratcorlu muratcorlu deleted the 252-select-issue branch September 29, 2022 10:49
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-beta.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bl-select's popover cannot be opened
3 participants