Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor button variants #271

Merged
merged 10 commits into from
Oct 6, 2022
Merged

Conversation

olkeoguz
Copy link
Contributor

@olkeoguz olkeoguz commented Oct 4, 2022

Includes refactoring button variants discussed in #250

Closes #250.

@olkeoguz olkeoguz self-assigned this Oct 4, 2022
@olkeoguz olkeoguz marked this pull request as draft October 4, 2022 13:38
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other components that uses button inside should also be updated (Alert, Select, Tab)

src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
src/components/button/bl-button.stories.mdx Outdated Show resolved Hide resolved
@olkeoguz olkeoguz marked this pull request as ready for review October 5, 2022 10:38
@muratcorlu
Copy link
Contributor

Latest changes causes an alignment issue on Select component. (border next to cancel button)

image

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@muratcorlu
Copy link
Contributor

Only thing is, this PR should include BREAKING CHANGE in merge commit message since it's changing current structure of the button component.

@olkeoguz olkeoguz changed the title feat: refactor button variants BREAKING CHANGE: refactor button variants Oct 5, 2022
@muratcorlu muratcorlu changed the title BREAKING CHANGE: refactor button variants feat: refactor button variants Oct 6, 2022
@muratcorlu muratcorlu merged commit b3e2a1e into next Oct 6, 2022
@muratcorlu muratcorlu deleted the 250-refactor-button-variants branch October 6, 2022 12:15
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🎉 This PR is included in version 2.0.0-beta.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring button variants
2 participants