feat(drawer): exit animation applied for drawer component #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes the snapshot tests for drawer component.
…-dont-work-properly
|
Kudos, SonarCloud Quality Gate passed! |
|
@buseselvi because I fixed screenshots of drawer, now proper snapshots of it are waiting for review. Some changes to remark:
|
buseselvi
approved these changes
Dec 7, 2022
olkeoguz
approved these changes
Dec 8, 2022
ozkersemih
reviewed
Dec 8, 2022
|
Kudos, SonarCloud Quality Gate passed! |
ozkersemih
approved these changes
Dec 8, 2022
muratcorlu
deleted the
329-drawer-component-visual-regression-tests-dont-work-properly
branch
|
🎉 This PR is included in version 2.0.0-beta.51 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the snapshot tests for drawer component. CSS animation was breaking the viewport size calculation of Chromatic. So together with @ozkersemih and @olkeoguz we decided to add a custom CSS property to allow changing animation duration. I didn't document this for now in purpose because we don't have a proper guidance about use-cases of changing animation duration. I believe we'll make animations more clear in general with #176 and documenting of this parameter will be also done properly after that.
Fixes #329