Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 18 support in development environment #361

Closed
muratcorlu opened this issue Jan 9, 2023 · 3 comments · Fixed by #526
Closed

Node 18 support in development environment #361

muratcorlu opened this issue Jan 9, 2023 · 3 comments · Fixed by #526
Labels
released on @beta released
Milestone
2023 Q2

Comments

@muratcorlu
Copy link
Contributor

Currently some parts of the Baklava development environment doesn't work with node 18. Since Node 18 is the new LTS version, this needs to be fixed.
@muratcorlu muratcorlu moved this to Selected in Baklava Design System Mar 24, 2023
@muratcorlu
Copy link
Contributor Author

Blocker part of this issue is Storybook. Current version of Storybook doesn't work properly with node 18 (storybookjs/storybook#21739). And apparently this will be fixed in storybook v7, which is in pre-release now. There is a workaround as using legacy provider but since node 18 version support is not that much critical for now and storybook v7 stable release seems to be released very soon, I'm eager to waiting for it.

Also source-map dependency needs to be upgraded. (mozilla/source-map#454)

@muratcorlu muratcorlu added this to the 2023 Q2 milestone Mar 28, 2023
@muratcorlu muratcorlu changed the title Node 18 support Node 18 support in development environment Apr 11, 2023
@AykutSarac AykutSarac mentioned this issue Apr 12, 2023
Merged
@muratcorlu muratcorlu moved this from Selected to In Development in Baklava Design System Apr 20, 2023
@github-project-automation github-project-automation bot moved this from In Development to Done in Baklava Design System May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

🎉 This issue has been resolved in version 2.1.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @beta released
Projects
Baklava Design System
Archived in project
Milestone
2023 Q2
Development

Successfully merging a pull request may close this issue.

chore(deps): support node v18
1 participant
@muratcorlu