Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input): step feature added for number input #371

Merged
merged 4 commits into from
Jan 20, 2023
Merged

feat(input): step feature added for number input #371

merged 4 commits into from
Jan 20, 2023

Conversation

yasin749
Copy link
Contributor

@yasin749 yasin749 commented Jan 16, 2023 •
edited by muratcorlu
Loading

Closes #370

@yasin749 yasin749 mentioned this pull request Jan 16, 2023
Closed
@yasin749 @muratcorlu
Update src/components/input/bl-input.stories.mdx
5271c9f 
Co-authored-by: Murat Çorlu <127687+muratcorlu@users.noreply.github.com>
Signed-off-by: Yasin UYSAL <yasin_749@hotmail.com>
muratcorlu
muratcorlu approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yasin749 Thanks for the contribution. That's a very good addition.

There is a problem in our pipeline that we hit multiple times (mentioned in #173). This time I want to fix that issue instead of walking around it. I'll create a PR to fix that issue first, then we can merge your work.

@yasin749
Copy link
Contributor Author

Thank you @muratcorlu

@muratcorlu muratcorlu merged commit 99f0f87 into Trendyol:next Jan 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.0.0-beta.62 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muratcorlu muratcorlu muratcorlu approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input Component Step Feature
2 participants
@yasin749 @muratcorlu