Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing Dialog with Escape should not cause exiting browser fullscreen #542

Closed
muratcorlu opened this issue Apr 21, 2023 · 2 comments · Fixed by #548
Closed

Closing Dialog with Escape should not cause exiting browser fullscreen #542

muratcorlu opened this issue Apr 21, 2023 · 2 comments · Fixed by #548
Labels
bl-dialog Issues related with Dialog component bug Something isn't working released on @beta released

Comments

@muratcorlu
Copy link
Contributor

In Safari, with full-screen, if you close a baklava dialog with Escape button, browser exits from fullscreen mode. We should prevent this.
@muratcorlu muratcorlu added bug Something isn't working bl-dialog Issues related with Dialog component labels Apr 21, 2023
@muratcorlu muratcorlu moved this from Selected to Ready for Development in Baklava Design System Apr 21, 2023
This was referenced Apr 21, 2023
Closed
Merged
@muratcorlu muratcorlu linked a pull request Apr 24, 2023 that will close this issue
fix(dialog): prevent exiting browser fullscreen with dialog close #548
Merged
@github-project-automation github-project-automation bot moved this from Ready for Development to Done in Baklava Design System Apr 26, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bl-dialog Issues related with Dialog component bug Something isn't working released on @beta released
Projects
Baklava Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): prevent exiting browser fullscreen with dialog close Trendyol/baklava
1 participant
@muratcorlu