feat(input): add readonly attribute #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was hesitant to add this property without any guidance since I was afraid that this can cause some usability issues and confusion on some use-cases. Either we can allow this first and consider side effects later, or maybe we can have a quick consideration to check if we can add some guide to avoid pitfalls -if any- of using this. @buseselvi |
|
Can you add this new parameter to the storybook file as well, so it can be controlled in story canvas in the docs? |
muratcorlu
approved these changes
Jun 7, 2023
|
🎉 This PR is included in version 2.2.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to this property for build date picker with baklava.