Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Can't prevent pressing Enter from input #676

Closed
1 task
Enes5519 opened this issue Aug 1, 2023 · 7 comments · Fixed by #691
Closed
1 task

[BUG]: Can't prevent pressing Enter from input #676

Enes5519 opened this issue Aug 1, 2023 · 7 comments · Fixed by #691
Labels
bug Something isn't working released

Comments

@Enes5519
Copy link
Contributor

Enes5519 commented Aug 1, 2023

Issue description

I prevent keydown event but not working. I don't want to trigger form element.

Media & Screenshots

No response

Baklava Version

2.2.0-beta.12

Operating system

  • OS: [e.g. iOS]: MacOS

  • Browser [e.g. chrome, safari]: Firefox

  • Any other details...

Priority this issue should have

Low (slightly annoying)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@Enes5519 Enes5519 added the bug Something isn't working label Aug 1, 2023
@AykutSarac
Copy link
Member

Can you try keydown capture event?

@Enes5519
Copy link
Contributor Author

Enes5519 commented Aug 2, 2023

We can add a prop and include it in the condition here, or we can also check whether the event is prevented or not, which I think will be the most effortless.

BTW I tried it didn't work.

@AykutSarac
Copy link
Member

Which component did you attach the keydown capture event?

@Enes5519
Copy link
Contributor Author

Enes5519 commented Aug 7, 2023

bl-input

@AykutSarac
Copy link
Member

I've attached capture event to form and it works for me.

@Enes5519
Copy link
Contributor Author

Enes5519 commented Aug 8, 2023

https://jsfiddle.net/enes5519/gp3k6bua/

@muratcorlu muratcorlu mentioned this issue Sep 8, 2023
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(input): prevent enter to submit form Trendyol/baklava
2 participants
@Enes5519 @AykutSarac