feat(select): work with auto width #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratcorlu
requested review from
buseselvi,
a team,
Enes5519 and
DamlaDemir
and removed request for
a team
buseselvi
approved these changes
Sep 17, 2023
AykutSarac
approved these changes
Sep 21, 2023
|
🎉 This PR is included in version 2.3.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
|
I noticed there seem to be some overflow problem with the sizing. Do you think it should have the size of max width of the select option or the select itself? 
|
|
If options are wider than select, popover should be bigger, I think that was our decision and we applied this in dropdown. Maybe we need a fix for select as well. Do you agree @buseselvi ? |
|
Yes, it would be nice to give the popover the ability to be wider than the input, like in the dropdown button. I think we will also need this when developing the date picker component in the future. |
Merged
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to our select working with
autosizing. If you setwidth: auto;to select component, it's width becomes fluid respected to its current label, placeholder, or selected value.Closes #693