fix(react): wrap with React.lazy #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muratcorlu
approved these changes
Sep 28, 2023
muratcorlu
approved these changes
Sep 28, 2023
Enes5519
reviewed
Sep 29, 2023
|
This worked in our project. Well done! |
|
🎉 This PR is included in version 2.3.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AykutSarac
added a commit
that referenced
this pull request
Sep 29, 2023
After looking into the discussion at [#716](#716 (comment)), I've noticed that we don't need to set the type manually as it's inferred from **React.lazy**. This will give us accurate type of the component and avoid mismatch. Additionally it fixes appending `undefined` for JSDoc to the `baklava-react.ts`. Co-authored-by: Aykut Saraç <aykut.sarac@trendyol.com>
Merged
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for recent generate react scripts change, adds back the forgotten React.lazy.
Before this change Baklava doesn't work with React 16.