Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting rules and making it part of workflow #77

Closed
1 task done
Tracked by #64
muratcorlu opened this issue Apr 6, 2022 · 0 comments · Fixed by #100
Closed
1 task done
Tracked by #64

Linting rules and making it part of workflow #77

muratcorlu opened this issue Apr 6, 2022 · 0 comments · Fixed by #100
Assignees
Milestone

Comments

@muratcorlu
Copy link
Contributor

muratcorlu commented Apr 6, 2022

  • Every linter should be run before pushing commits (with husky) and in github actions on every push.

tslint, eslint, prettier, csslint, postcss should be considered in this issue.

Our main expectations from those linters are;

  • Every coding file that we write should follow the standards that we defined. And those linters should guarantee this to us.
  • Linters should prevent doing some basic mistakes by checking some rules.
@muratcorlu muratcorlu mentioned this issue Apr 6, 2022
64 tasks
@leventozen leventozen self-assigned this Apr 7, 2022
@leventozen leventozen linked a pull request Apr 17, 2022 that will close this issue
2 tasks
@muratcorlu muratcorlu added this to the v2.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants