feat: add reflector

[JaimeTorrealba]

No description provided.

[netlify]

✅ Deploy Preview for cientos-tresjs ready!

Name	Link
🔨 Latest commit	994d35e
🔍 Latest deploy log	https://app.netlify.com/sites/cientos-tresjs/deploys/6553b92401a0df0008aa35db
😎 Deploy Preview	https://deploy-preview-136--cientos-tresjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alvarosabu]

Hi @JaimeTorrealba excellent job, I love the result.

I think we should add this to abstractions instead of materials because this implementation actually doesn't solve #5, it's not a Material but I see it as a handy abstraction from 'three/addons/objects/Reflector'

The #5 is an actual material, to be used like this:

<TresMesh >
      <TresPlaneGeometry />
      <MeshReflectorMaterial blur="[300, 100]" resolution="2048" />
</TresMesh>

Another question would be, how are you handling the reactivity of those props?

[alvarosabu]

Docs build is broken, can you check the build locally?

[JaimeTorrealba]

@alvarosabu could be related to this doc's problem #137

[JaimeTorrealba]

In relation to the other comment, You're right is not a material, I'll move it, but It solves the exact same problem of the #5.
Are you sure you don't want to close it?? I mean obviously need some changes in the shaders but the effect you can achieve is the same

As the properties are in the args (And because of the way the Reflector class have been built in, I couldn't figure out how to make reactive props) only the color is reactive

[alvarosabu]

For the ticket leave it open, the idea would be to eventually create te reflector material.

For the reactivity I give you a small clue since you can get the reference of the instance, if one of the argument changes (watch) you could potentially dispose it and re initialize it with the new args.

Give it a though 😉

[JaimeTorrealba]

I tried already but nothing work, nor dispose the material, geometry.

Nothing works, I Guess I am doing something wrong :(

[alvarosabu]

@JaimeTorrealba can you merge latest main and update this PR, it has been around for long

[JaimeTorrealba]

@alvarosabu I already merge main in this one.

Is not ready yet for merging to main, because is not reactive, when you have some time check it please. If you have any doubts, please let me know.

[andretchen0]

Looks good. Here are my suggestions.

[andretchen0]

Looks good to me!

[alvarosabu]

Hey @JaimeTorrealba awesome to see this updated, can you add a demo to the documentation, this one is especially visual, it would be nice.

[alvarosabu]

@JaimeTorrealba Thanks for this, looks amazing, great job