Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not resolve "@tweakpane/plugin-essentials" since at least Cientos 3.1.0 #179

Closed
5 tasks done
bperel opened this issue Aug 23, 2023 · 3 comments · Fixed by #180
Closed
5 tasks done

Could not resolve "@tweakpane/plugin-essentials" since at least Cientos 3.1.0 #179

bperel opened this issue Aug 23, 2023 · 3 comments · Fixed by #180

Comments

@bperel
Copy link
Contributor

bperel commented Aug 23, 2023

Describe the bug

I am doing: vite
I expect: vite to load without error, like it did for cientos < 3
What is actually happening:

  VITE v4.4.9  ready in 1502 ms

  ➜  Local:   http://127.0.0.1:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help
Could not resolve "@tweakpane/plugin-essentials"

    node_modules/.pnpm/@tresjs+cientos@3.1.0_three@0.154.0_tweakpane@4.0.0_vue@3.3.4/node_modules/@tresjs/cientos/dist/trescientos.js:15:20:
      15 │ import * as xo from "@tweakpane/plugin-essentials";
         ╵                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@tweakpane/plugin-essentials" as external to exclude it from the bundle,
  which will remove this error.

 ELIFECYCLE  Command failed with exit code

Reproduction

https://stackblitz.com/edit/tresjs-basic-hkgcpb?file=package.json

Steps to reproduce

npm install && npm run dev

System Info

No response

Used Package Manager

npm

Code of Conduct

@bperel bperel changed the title Could not resolve "@tweakpane/plugin-essentials" Could not resolve "@tweakpane/plugin-essentials" since at least Cientos 3.1.0 Aug 23, 2023
@alvarosabu
Copy link
Member

Since v3.1.0 tweakpane and @tweakpane/plugin-essentials are not longer part of the bundle, they need to be installed as peer dep, just install the package

@bperel
Copy link
Contributor Author

bperel commented Aug 23, 2023

Since v3.1.0 tweakpane and @tweakpane/plugin-essentials are not longer part of the bundle, they need to be installed as peer dep, just install the package

In that case should it be part of the installation documentation? In the Stackblitz I don't use Tweakpane so I didn't expect to need to install this dependency

@alvarosabu
Copy link
Member

alvarosabu commented Aug 23, 2023

@bperel we are going to start deprecating useTweakpane from cientos, for now the fix above will prevent your code from breaking, you can continue by using @tresjs/cientos@next or waiting for the PR to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants