Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers diposal error since latest threejs update #682

Closed
5 tasks done
alvarosabu opened this issue May 15, 2024 · 1 comment
Closed
5 tasks done

Helpers diposal error since latest threejs update #682

alvarosabu opened this issue May 15, 2024 · 1 comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) regression The issue only appears after a new release v4

Comments

@alvarosabu
Copy link
Member

alvarosabu commented May 15, 2024

Describe the bug

There is an issue with the automatic disposal, some elements like

  • GridHelper
  • AxesHelper

Are throwing this error when the scene is unmounted

chunk-SRLW6FY7.js?v=a19e4a6b:30745 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'dispose')
    at AxesHelper.dispose (chunk-SRLW6FY7.js?v=a19e4a6b:30745:19)

Reproduction

local playground

Steps to reproduce

  • Run playground with npm run dev
  • Open conditional example
  • Go back

System Info

System:
    OS: macOS 14.3.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 60.73 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    bun: 1.0.2 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: 120.1.61.116
    Chrome: 124.0.6367.207
    Safari: 17.3.1
  npmPackages:
    @tresjs/cientos: 3.8.0 => 3.8.0 
    @tresjs/core: workspace:^ => 4.0.0-rc.0 
    @tresjs/leches: 0.15.0-next.3 => 0.15.0-next.3

Used Package Manager

pnpm

Code of Conduct

@alvarosabu alvarosabu added bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) regression The issue only appears after a new release v4 labels May 15, 2024
@Sea-DH1
Copy link

Sea-DH1 commented May 16, 2024

This version of Box3Helper still has this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) regression The issue only appears after a new release v4
Projects
Status: Done
Development

No branches or pull requests

2 participants