Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rigged models are squished and broken #751

Closed
5 tasks done
alvarosabu opened this issue Jun 29, 2024 · 3 comments · Fixed by #764
Closed
5 tasks done

Rigged models are squished and broken #751

alvarosabu opened this issue Jun 29, 2024 · 3 comments · Fixed by #764
Assignees
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) upstream Bug in a dependency of Tres

Comments

@alvarosabu
Copy link
Member

alvarosabu commented Jun 29, 2024

Describe the bug

Adding a rigged model with useGLTF looks squished and broken

Screenshot 2024-06-29 at 11 53 14

Reproduction

https://stackblitz.com/~/edit/tresjs-squished-models?file=src/App.vue

Steps to reproduce

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @tresjs/cientos: 3.9.0 => 3.9.0 
    @tresjs/core: 4.0.2 => 4.0.0 
    vite: ^5.3.2 => 5.3.2

Used Package Manager

npm

Code of Conduct

@alvarosabu alvarosabu added bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) labels Jun 29, 2024
@alvarosabu alvarosabu changed the title Models with rigs are squished and broken Rigged models are squished and broken Jun 29, 2024
@alvarosabu
Copy link
Member Author

cc @andretchen0 so you have it on your radar, seems like a regression bug from the core v4. It might be related to changes on primitives. Could you please check if in your PR with the new approach on primitives this is solved? Thanks

@alvarosabu alvarosabu added the upstream Bug in a dependency of Tres label Jun 29, 2024
@alvarosabu
Copy link
Member Author

Seems to be a regression issue related to primitives changes from core v3.9.0 -> v4.0.0. Will move this to the core package

@alvarosabu alvarosabu transferred this issue from Tresjs/cientos Jun 29, 2024
@andretchen0
Copy link
Contributor

In case it's useful in the future, here's the change that caused the regression:

79d8a76#diff-505c62067e9b13b6e4515b24b16c4ac03af37d111601d5a81acf355af29c8fc5L52

Changes to the primitive implementation are currently underway. The model displays and animates as expected with the new WIP implementation:

Screenshot 2024-06-29 at 17 52 57

@alvarosabu alvarosabu moved this to Todo in Team Board Jul 5, 2024
@andretchen0 andretchen0 self-assigned this Jul 8, 2024
@alvarosabu alvarosabu moved this from Todo to In Progress in Team Board Jul 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Board Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) upstream Bug in a dependency of Tres
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants