-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple language support #57
Comments
Great idea! I have started implementing a locale system from QBCore. Once finished I will push a commit, feel free to PR additional locale / languages to support as I will likely only be providing a base english option. Beware though, LVC has many many (dare I say many again) strings.. |
Perfect! Then I'll wait for your commit and extend that with another language (in that case that would be German). But I have one more question. Do you implement all the used parts of QBCore in this script or will there be a dependency to QBCore? Because for me as an ESX user the latter would not be really good. Then I would have to implement a workaround. "Beware though, LVC has many many (dare I say many again) strings.." |
Because QBCore is a GNU licensed open-source project, I am "borrowing" (with due copyright given) the small piece of code that manages locales. It will be included with the standard download and will not require any dependancies or have any conflicts with other frameworks. |
d7f2b77 There are a ton of strings, feedback is welcome :) |
Overall everything looks wonderful! |
Just realized I added all the plugins to support translation, but when committing I must have override my progress, so plugins are still messed up. |
Another thing: |
Fixed 14ea34f |
Hello all!
Is there any interest here to support multiple languages? I have to manually convert translations every time I update.
I could very well imagine working here, as in many other scripts, with an extra 'locales' folder and existing locale files for each supported language.
If such support is desired, then I would be willing to implement this conversion and create a pull request for later review.
Best regards
Dustin
The text was updated successfully, but these errors were encountered: