-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to GitHub Actions #1279
Comments
Side note: this issue only covers tests due to (proposed) merges. Our network health jobs (peer discovery health, default community peer discovery health, and bootstrap connectivity) would remain on Jenkins. |
We got to the "very very very last thing" a lot sooner than I expected. However, there are some issues with resolving this last bullet point. I'll scale down this issue to low priority. |
Apparently the MutPy changes are not lost at all. https://github.com/Tribler/py-ipv8-mutation-libraries/issues/1#issue-771999920 In that case, we can clean everything up neatly. |
Once Tribler/mutpy#1 is resolved, this repo should make use of the sanitized fork. Then the approach of #1254 (comment) could be followed to implement the GitHub Action. |
The mutpy fork issue has now been resolved. An bin/github_report.py --codebase ipv8 |
We've had several PR test outages due to Jenkins updates over the last few months.
Depending on the outage, the resolution to these outages took me from a few minutes up to multiple days.
It's probably a better use of my/our time to port our jobs to GitHub Actions. The following PR tests would need to be ported:
Additionally, we may want to port the three remaining validation checks (the cross-env check is already in GitHub Actions):
The post-merge tests still seem to be working reliably (Mutation tests + Linux, Mac, Windows coverage listed in the README). Perhaps we should port these at a later date. If we do end up porting these, it concerns the following jobs (we don't really care about the Python versions here):
The text was updated successfully, but these errors were encountered: