Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.5.0-RC5] MetadataStore and GigaChannelManager shutdown sequence error #5297

Closed
devos50 opened this issue Apr 22, 2020 · 2 comments
Closed

[7.5.0-RC5] MetadataStore and GigaChannelManager shutdown sequence error #5297

devos50 opened this issue Apr 22, 2020 · 2 comments
Assignees
@ichorid
Labels
type: bug

Comments

@devos50
Copy link
Contributor

devos50 commented Apr 22, 2020

Found this in the log when shutting down Tribler. Even though it did not crash Tribler, it might be the case that the channel processing procedure is not shut down correctly (since the metadata store is already set to None while the channel is still processing).

[PID:4931] 2020-04-22 10:46:54,838 - ERROR <gigachannel_manager:266> GigaChannelManager._process_download(): Error when processing channel dir download: 'NoneType' object has no attribute '_db'
@devos50 devos50 added this to the V7.5: core refactoring milestone Apr 22, 2020
@ichorid
Copy link
Contributor

ichorid commented May 4, 2020

Indeed, this points to a bigger problem of shutdown sequence being a mess between GigaChannelManager and MetadataStore. To solve it properly, the channel-processing and thread-handling functionality should be arranged between them differently. I'm not sure this is worth it at RC5 stage.

@ichorid ichorid changed the title [7.5.0-RC5] Error when processing channel dir download: 'NoneType' object has no attribute '_db' [7.5.0-RC5] MetadataStore and GigaChannelManager shutdown sequence error May 4, 2020
@ichorid ichorid self-assigned this Jul 15, 2020
@drew2a drew2a modified the milestones: Next-next release, Backlog Sep 15, 2021
@ichorid
Copy link
Contributor

ichorid commented Sep 24, 2021

Most probably solved by #6335 .

@ichorid ichorid closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichorid ichorid

Labels
type: bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devos50 @ichorid @drew2a