Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Tribler build broken #6249

Closed
devos50 opened this issue Aug 12, 2021 · 3 comments · Fixed by #6256
Closed

[main] Tribler build broken #6249

devos50 opened this issue Aug 12, 2021 · 3 comments · Fixed by #6256

Comments

@devos50
Copy link
Contributor

devos50 commented Aug 12, 2021

Building Tribler is broken after merging #6206, on all platforms, see here.

Stack trace:

Traceback (most recent call last):
  File "/usr/local/bin/pyinstaller", line 8, in <module>
    sys.exit(run())
  File "/usr/local/lib/python3.8/site-packages/PyInstaller/__main__.py", line 114, in run
    run_build(pyi_config, spec_file, **vars(args))
  File "/usr/local/lib/python3.8/site-packages/PyInstaller/__main__.py", line 65, in run_build
    PyInstaller.building.build_main.main(pyi_config, spec_file, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/PyInstaller/building/build_main.py", line 725, in main
    build(specfile, kw.get('distpath'), kw.get('workpath'), kw.get('clean_build'))
  File "/usr/local/lib/python3.8/site-packages/PyInstaller/building/build_main.py", line 672, in build
    exec(code, spec_namespace)
  File "tribler.spec", line 28, in <module>
    from tribler_core.modules.ipv8_module_catalog import get_hiddenimports as ipv8_module_imports
ModuleNotFoundError: No module named 'tribler_core.modules.ipv8_module_catalog'
@xoriole
Copy link
Contributor

xoriole commented Aug 12, 2021

Tested the build on the latest main, there are no ipv8 hidden imports anymore, simply removing those hidden imports from tribler.spec seems to fix the build. However, there seems to be issue with build on linux with dch debian changelog (silent pass on failure) and pending MacOS (pip upgrade issue).

https://jenkins-ci.tribler.org/job/Build-Tribler_release/job/Build/259/

@xoriole
Copy link
Contributor

xoriole commented Aug 23, 2021

Build on MacOS, Windows and Linux is fixed but there is an issue on building the source tar.

+ python3 build/update_version_from_git.py
Traceback (most recent call last):
  File "build/update_version_from_git.py", line 57, in <module>
    run_command('dch -v {} New upstream release.'.format(version_id).split())
  File "build/update_version_from_git.py", line 16, in run_command
    p = Popen(cmd, stdout=PIPE, stderr=PIPE)
  File "/usr/lib/python3.6/subprocess.py", line 729, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.6/subprocess.py", line 1364, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'dch': 'dch'

dch is resolved by installing devscripts.

+ python3 build/update_version_from_git.py

Traceback (most recent call last):
  File "build/update_version_from_git.py", line 57, in <module>
    run_command('dch -v {} New upstream release.'.format(version_id).split())
  File "build/update_version_from_git.py", line 18, in run_command
    assert(p.returncode == 0)
AssertionError

The issue lies with the changelog

https://jenkins-ci.tribler.org/job/Build-Tribler_release/job/Build/261/

@xoriole
Copy link
Contributor

xoriole commented Sep 20, 2021

Fixed by #6302

@xoriole xoriole closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants