Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status code check in REST API tests is broken #6431

Closed
devos50 opened this issue Oct 7, 2021 · 0 comments · Fixed by #6432
Closed

Status code check in REST API tests is broken #6431

devos50 opened this issue Oct 7, 2021 · 0 comments · Fixed by #6432

Comments

@devos50
Copy link
Contributor

devos50 commented Oct 7, 2021

It seems that after merging #6206, the status code check in the REST API tests is broken (see here for the code change). The check is currently as follows:

assert expected_code, response == status

However, this is merely checking whether expected_code is true (i.e., non-zero), and if the assert fails, it will print response == status as the reason. We should fix this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant