Remove list comprehension from str.join function calls

[Solomon1732]

Describe the bug
Thanks to generator expressions and other lazy evaluation functions (such as map), there's no need to build a list when calling str.join. This saves memory during runtime since no list is built. Below each relevant line I wrote a substitute I offer.

tribler/src/tribler/core/components/libtorrent/torrentdef.py

Line 306 in 8df8154

return "".join([filter_character(char) for char in name])

                    return "".join(map(filter_character, name))

tribler/src/tribler/core/components/libtorrent/torrentdef.py

Line 386 in 8df8154

return "".join([filter_character(char) for char in name])

                            return "".join(map(filter_character, name))

tribler/src/tribler/core/components/metadata_store/remote_query_community/payload_checker.py

Line 104 in 8df8154

" ".join(

                " ".join(getattr(self.payload, attr) for attr in ("title", "tags", "text") if hasattr(self.payload, attr))

tribler/src/tribler/core/components/libtorrent/restapi/downloads_endpoint.py

Line 53 in 8df8154

return ''.join([chr(c) for c in ext_peer_info])

        return ''.join(map(chr, ext_peer_info))

• Tribler's version [main branch]

[drew2a]

@Solomon1732 thank you for your contributions to improving Tribler's code quality. If it's not too much trouble, could you kindly convert this issue into a pull request? This way, we could avoid duplication of work, as it would save us the step of implementing the string replacements that you've described. Plus, we could run tests on the modified code to ensure its correctness.
Thank you in advance for your consideration.

[Solomon1732]

No problem. I would be glad to 😄