Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsable sections/blocks #121

Open
meichthys opened this issue May 9, 2024 · 6 comments
Open

Collapsable sections/blocks #121

meichthys opened this issue May 9, 2024 · 6 comments
Labels
ckeditor Related to ckeditor enhancement New feature or request ported-issues Feature requests ported from zadam/trilium

Comments

@meichthys
Copy link
Contributor

meichthys commented May 9, 2024

zadam/trilium#1894

@meichthys meichthys added enhancement New feature or request ported-issues Feature requests ported from zadam/trilium labels May 9, 2024
@dwdcth
Copy link

dwdcth commented Nov 19, 2024

This feature is very practical, looking forward to it.

@eliandoran
Copy link
Contributor

@meichthys , I think there are two different features here, one is for collapsible sections (zadam/trilium#1894) and another for collapsible bullets (zadam/trilium#1850). Maybe we should split the ticket to reflect this.

@eliandoran
Copy link
Contributor

This feature is very practical, looking forward to it.

Which one of the two are you referring to?

If you are referring to collapsible section, unfortunately I don't see this happening very soon. We are depending on the CKEditor team to implement it and from what I saw with the code blocks, adding new features does not seem to be on the top of their priorities.

For collapsible bullets, I saw there was a custom widget implemented to add support for this.

@meichthys meichthys changed the title collapsable sections (tied with editor changes) Collapsable sections/blocks Nov 19, 2024
@meichthys meichthys added the ckeditor Related to ckeditor label Nov 19, 2024
@meichthys
Copy link
Contributor Author

meichthys commented Nov 19, 2024

@meichthys , I think there are two different features here, one is for collapsible sections (zadam#1894) and another for collapsible bullets (zadam#1850). Maybe we should split the ticket to reflect this.

Agreed. See #614 for the new issue related to collapsing bullets (and a custom widget to accomplish this).

Also see here for some ckeditor issues related to collapsible sections:
ckeditor/ckeditor5#11068
ckeditor/ckeditor5#8457

@CobriMediaJulien
Copy link
Contributor

Just to inform you. The widget if from @zerebos. The widget has a bug and somtimes the arrow to collapse the bullets doesnt appear or is invisible. I had both cases.. If this happens make sure u dont have the skript open in a tab. reload frontend. open a side with collapsable bullets. Open the side again in a new tab and drag and drop it into a new window.

the code is somehow not workign in trilium next like in trilium.

@CobriMediaJulien
Copy link
Contributor

ckeditor/ckeditor5#17264

Let´s support block referenced in the CKEditor repo. The devs are asking for feedback and thought allrdy about implementing unique block references. But i think we have to show them that it´s a needed feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ckeditor Related to ckeditor enhancement New feature or request ported-issues Feature requests ported from zadam/trilium
Projects
None yet
Development

No branches or pull requests

4 participants