NavBar extended middleware #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthonyp0329
requested review from
a team,
EdwardLinS and
meganleongg
and removed request for
a team
Anthonyp0329
requested changes
May 29, 2024
| } | ||
|
|
||
| const port = process.env.DEV_PORT || 3001; | ||
| const CATEGORIES_URL = `http://localhost:${port}/api/categories`; |
There was a problem hiding this comment.
Make sure to have this url pull from a .env so it works in deployment. Lillian and Edwards pr has a similar file though, maybe you can just use this one once their pr is merged
| })(); | ||
| }, []); | ||
|
|
||
| const generalPrinciples = items.filter(category => category.type === 'General Principle'); |
There was a problem hiding this comment.
Make sure there is a tab called 'All' at the top:
EdwardLinS
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #37
Changes
Added middleware to make general categories pull data from backend. Also added blank component template for each sub-category.
Testing
Checked dev tools to make sure data received from backend, tested admin on localhost to see frontend changes
Confirmation of Change