New Rule: don't self-assign variables or columns

[silviomarghitola]

Language Usage / General
never assign a column or variable to itself

[PhilippSalvisberg]

from SonarSource:

Variables and columns should not be self-assigned

here is no reason to re-assign a variable to itself. Either this statement is redundant and should be removed, or the re-assignment is a mistake and some other value or variable was intended for the assignment instead.

Noncompliant Code Example

UPDATE person
SET name = name;

Compliant Solution

UPDATE person
SET name = UPPER(name);

[PhilippSalvisberg]

makes sense.

Notes: All assignments should be considered for the PL/SQL Cop check.

[RichardSoule]

As an aside, one exception would be when attempting to fire cross edition triggers when using Edition Based Redefinition. You may (or may not) want to include that exception.

[kibeha]

Made it two rules:

• One for variable self-assignment using "Never".
• One for column self-assignment using "Avoid" and mentioning the trigger firing exception.