Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework network option passing and resolution #50

Open
wachulski opened this issue Nov 12, 2021 · 0 comments
Open

Rework network option passing and resolution #50

wachulski opened this issue Nov 12, 2021 · 0 comments
Assignees
@wachulski
Labels
technical Technical changes that does not change features

Comments

@wachulski
Copy link
Contributor

Currently network option may be:

  1. network name like 'mainnet'
  2. network RPC url (when starting with http)
  3. 🕵🏻‍♂️ Add support for impersonating (signing) as unlocked account #47 -> as Ganache.Provider

this complicates getSigner in config.ts

Refactor this.

Idea:
Improve by introducing disciminated union types (possibly combining with infura/alchemy API keys).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wachulski wachulski

Labels
technical Technical changes that does not change features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wachulski