-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better exception handling #8
Comments
I think we resolved this last week, right? |
I did something briefly on it, just capturing and recording exceptions thrown by the CfiVerifier when executing CfiDriver. I think it's worth having a look and doing something more sophisticated. |
Added some more comprehensive exception logging in commit 1bdbb65. Maybe revisit in the future? |
Nevermind, apparently the "try..catch" blocks in the CfiDriver which calls the other executables do not actually catch the thrown exception by the process. |
Do you think we need to improve exception handling now? Or should we close this? |
It's the same status as before: there is no exception handling. The subprocesses do not throw exception as they "successfully" terminate, albeit throwing an exception. Thus, the "try...catch" blocks around the subprocess calls are dead code. For the moment, I didn't see any crashes in recent experiments, which means we could leave it be. However, for the future, I think this should be taken into consideration. |
Rather than throwing an exception in the CfiDriver, should gather all instances of no produced assertions and report them at the end.
The text was updated successfully, but these errors were encountered: