Skip to content

Commit

Permalink
feat(node): add initial node v12 support & update min versions (#1003)
Browse files Browse the repository at this point in the history
- update minimum versions of node 8 & 10 to latest security patches
- add node v12 to supported versions & travis testing (note: allow_failures is set because no public version of Ghost supports node 12 yet)
  • Loading branch information
acburdine authored Oct 13, 2019
1 parent e0bcbae commit 212f4aa
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
22 changes: 16 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,31 @@
dist: xenial
language: node_js
node_js:
- 8
- 10
- 8
- 10

cache: yarn

jobs:
include:
- node_js: "10"
- node_js: '10'
env: TEST_SUITE=lint
- node_js: '12'
allow_failures:
- node_js: '12'

# Don't run builds for renovate PRs
if: NOT head_branch =~ ^renovate

script:
- if [ "$TEST_SUITE" == "lint" ]; then yarn run lint; else yarn run test:all; fi
script: |
if [ "$TEST_SUITE" == "lint" ]; then
yarn lint
elif [ "$TRAVIS_NODE_VERSION" == "12" ]; then
yarn test:unit
GHOST_NODE_VERSION_CHECK=false yarn test:acceptance
else
yarn test:all
fi
after_success:
- if [[ "$TRAVIS_NODE_VERSION" == "10" && "$TEST_SUITE" != "lint" ]]; then yarn run coverage; fi
- if [[ "$TRAVIS_NODE_VERSION" == "10" && "$TEST_SUITE" != "lint" ]]; then yarn coverage; fi
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
]
},
"engines": {
"node": "^8.10.0 || ^10.13.0"
"node": "^8.16.0 || ^10.16.0 || ^12.11.0"
},
"preferGlobal": true,
"dependencies": {
Expand Down

0 comments on commit 212f4aa

Please sign in to comment.