fix(ui): default exitOnError to true in listr opts

TryGhost · Oct 11, 2018 · 58806da · 58806da
1 parent c81070c
commit 58806da
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/ui/index.js b/lib/ui/index.js
@@ -193,7 +193,8 @@ class UI {
      */
     listr(tasks, context, options) {
         const listrOpts = Object.assign({
-            renderer: this.verbose ? 'verbose' : this.Renderer
+            renderer: this.verbose ? 'verbose' : this.Renderer,
+            exitOnError: true
         }, options || {});
 
         const listr = new Listr(tasks, listrOpts);

diff --git a/test/unit/ui/index-spec.js b/test/unit/ui/index-spec.js
@@ -393,8 +393,9 @@ describe('Unit: UI', function () {
                 expect(ListrStub.calledWithNew()).to.be.true;
                 expect(createRendererStub.calledOnce).to.be.true;
                 expect(ListrStub.calledWithExactly(tasks, {
-                    renderer: {RendererClass: true}
-                }));
+                    renderer: {RendererClass: true},
+                    exitOnError: true
+                })).to.be.true;
                 expect(runStub.calledOnce).to.be.true;
                 expect(runStub.calledWithExactly({
                     ui: ui,
@@ -419,8 +420,8 @@ describe('Unit: UI', function () {
                 expect(createRendererStub.called).to.be.false;
                 expect(ListrStub.calledWithExactly(tasks, {
                     renderer: 'verbose',
-                    exitOnError: true
-                }));
+                    exitOnError: false
+                })).to.be.true;
                 expect(runStub.calledOnce).to.be.true;
                 expect(runStub.calledWithExactly({
                     something: 'foo',
@@ -437,13 +438,13 @@ describe('Unit: UI', function () {
             const ui = new UI();
             const tasks = ['test','ing','is','necessary'];
 
-            const result = ui.listr(tasks, false, {exitOnError: false, renderer: 'update'});
+            const result = ui.listr(tasks, false, {renderer: 'update'});
             expect(result).to.deep.equal({run: runStub});
             expect(ListrStub.calledWithNew()).to.be.true;
             expect(ListrStub.calledWithExactly(tasks, {
                 renderer: 'update',
                 exitOnError: true
-            }));
+            })).to.be.true;
             expect(runStub.called).to.be.false;
         });
     });