fix(check-update): fixed output for current major

- don't output the latest minor in current major if we're already on the latest major
TryGhost · May 20, 2022 · b72c25b · b72c25b
1 parent 5b83003
commit b72c25b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/commands/check-update.js b/lib/commands/check-update.js
@@ -15,7 +15,7 @@ class CheckUpdateCommand extends Command {
 
             this.ui.log(`Current version: ${chalk.cyan(instance.version)}`);
 
-            if (latestMinor && semver.gt(latestMinor, instance.version)) {
+            if (latestMinor && semver.neq(latestMinor, instance.version) && semver.neq(latestMinor, latest)) {
                 this.ui.log(`Latest ${currentMajor}.x version: ${chalk.cyan(latestMinor)}`);
             }
 

diff --git a/test/unit/commands/check-update-spec.js b/test/unit/commands/check-update-spec.js
@@ -36,7 +36,7 @@ describe('Unit: Commands > check-update', function () {
     });
 
     it('logs out available new version', async function () {
-        const loadVersions = sinon.stub().resolves({latest: '2.1.0', latestMajor: {v1: '1.0.0'}});
+        const loadVersions = sinon.stub().resolves({latest: '2.1.0', latestMajor: {v1: '1.0.0', v2: '2.1.0'}});
         const CheckUpdateCommand = proxyquire(modulePath, {
             '../utils/version': {loadVersions}
         });
@@ -72,7 +72,7 @@ describe('Unit: Commands > check-update', function () {
     });
 
     it('logs out available new major version when on latest minor', async function () {
-        const loadVersions = sinon.stub().resolves({latest: '4.1.0', latestMajor: {v1: '1.0.0', v2: '2.0.0', v3: '3.42.0'}});
+        const loadVersions = sinon.stub().resolves({latest: '4.1.0', latestMajor: {v1: '1.0.0', v2: '2.0.0', v3: '3.42.0', v4: '4.1.0'}});
         const CheckUpdateCommand = proxyquire(modulePath, {
             '../utils/version': {loadVersions}
         });