Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ls command): don't render table when no instances found #682

Merged

Conversation

vikaspotluri123
Copy link
Member

no issue

Currently, when a user runs ghost ls and has no installed ghost instances, they just get a table header. This can be confusing, so instead, we're outputting a more informative message of "No installed ghost instances found"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 65aa5bf on vikaspotluri123:feat/no-instances-available into 5552a0e on TryGhost:master.

Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acburdine acburdine merged commit b250953 into TryGhost:master Mar 25, 2018
@vikaspotluri123 vikaspotluri123 deleted the feat/no-instances-available branch March 25, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants