fix(migrations): Use proper permissions to create content/settings folder #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@e-nomem Thank you very much!!! This is totally necessary! We just need to fix the tests... |
vikaspotluri123
pushed a commit
to vikaspotluri123/Ghost-CLI
that referenced
this pull request
Apr 25, 2018
…lder (TryGhost#703) no issue Fixes an issue where the migration wouldn't have the correct permission the create the new folder within the content directory, when it's owned by the `ghost` user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating from CLI version
1.6.0to1.7.0, the newcontent/settingsdirectory is not properly created since thecontentdirectory is owned by theghostuser and not my running user.The fix here is to check the owner of the directory first and use
sudoas appropriate.It's getting late here so I'll come back for the failing tests later unless someone here wants to fix them up.