Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system): improve hasInstance check #940

Merged
merged 1 commit into from
May 30, 2019

Conversation

acburdine
Copy link
Member

@acburdine acburdine commented May 30, 2019

refs #936

  • check if name matches global config name as well

The problem (I think) is that if you delete the contents of a ghost install directory without running ghost uninstall, the entry in ~/.ghost/config never gets removed, and thus if you attempt to install Ghost in the same directory again, the hasInstance check would happily report that the instance had already been set up. This expands the check to also check the name field.

Note: upon further thought this may only fix half of the issue - may need a follow-up PR to expand the check in the isSetup getter in the instance class.

refs TryGhost#936
- check if name matches global config name as well
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 51828d9 on acburdine:fix/system-hasinstance into 527104b on TryGhost:master.

@acburdine acburdine merged commit aad60a6 into TryGhost:master May 30, 2019
@acburdine acburdine deleted the fix/system-hasinstance branch May 30, 2019 11:48
@acburdine acburdine added this to the 1.10.1 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants