fix(system): improve hasInstance check #940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #936
The problem (I think) is that if you delete the contents of a ghost install directory without running
ghost uninstall
, the entry in~/.ghost/config
never gets removed, and thus if you attempt to install Ghost in the same directory again, the hasInstance check would happily report that the instance had already been set up. This expands the check to also check the name field.Note: upon further thought this may only fix half of the issue - may need a follow-up PR to expand the check in the
isSetup
getter in the instance class.