Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): allow root user to run config command #982

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

acburdine
Copy link
Member

closes #981

  • this enables the config command to be run as the root user

closes TryGhost#981
- this enables the config command to be run as the root user
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9ee64d3 on acburdine:fix/config-allow-root into 7974124 on TryGhost:master.

@bobhy
Copy link

bobhy commented Jul 21, 2019

I like the intent of this change, but the default should probably be false to preserve backward compatibility.

@acburdine
Copy link
Member Author

@bobhy it is undefined on all commands by default, which given the way it's used is equivalent to false by default, see https://github.com/TryGhost/Ghost-CLI/blob/master/lib/command.js#L148

@acburdine acburdine merged commit 870fd0d into TryGhost:master Oct 22, 2019
@acburdine acburdine deleted the fix/config-allow-root branch October 22, 2019 22:55
@devinowen
Copy link

Hey team! Does this change allow you to run ghost start or ghost run as the root user? If so, how should I pass that param?

@vikaspotluri123
Copy link
Member

@devinowen this PR only allows the config command to be run as root, it doesn't modify the behavior of start / run

@devinowen
Copy link

Thanks @vikaspotluri123!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghost CLI won't run in (community supported) ghost docker image
5 participants