Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n/l10n] Multi-lang sites: Translateable navigation labels & site data #11444

Closed
heyakyra opened this issue Dec 15, 2019 · 1 comment
Closed
Labels
stale [triage] Issues that were closed to to lack of traction

Comments

@heyakyra
Copy link

heyakyra commented Dec 15, 2019

Issue Summary

For proper internationalization, all site-wide data including navigation labels should be translatable and it should be possible to load that data based on either the route or the language of the post being viewed. Currently, there is a confusing misalignment of theme translation features and multi-language site features. See also: #8509

Data needing translations includes:

  • Navigation labels
  • Site title & description
  • Site metadata

Data needing translations and/or a language property:

  • Site pages
  • Blog posts

The API Reference for Handlebars Themes' "translate" section says:

To ensure that your theme is fully translatable, two core templates must exist in your theme. Check the following templates exist:

pagination.hbs - exists in content/themes/mytheme/partials, copy the template

navigation.hbs - exists in content/themes/mytheme/partials, copy the template

While there are instructions for translating pagination at the end of the section, translations within locale files do not apply to navigation labels by default and there are no instructions for achieving this.

The section on subexpressions implies but doesn't clearly say whether (and if so, how) this could be used to translate arbitrary text returned by handlebar expressions.

@heyakyra heyakyra changed the title [i18n] Navigation labels & site data should be translateable Multi-lang sites: Translateable navigation labels & site data Dec 15, 2019
@heyakyra heyakyra changed the title Multi-lang sites: Translateable navigation labels & site data [i18n/l10n] Multi-lang sites: Translateable navigation labels & site data with Fluent Jan 17, 2020
@heyakyra heyakyra changed the title [i18n/l10n] Multi-lang sites: Translateable navigation labels & site data with Fluent [i18n/l10n] Multi-lang sites: Translateable navigation labels & site data with Jan 17, 2020
@heyakyra heyakyra changed the title [i18n/l10n] Multi-lang sites: Translateable navigation labels & site data with [i18n/l10n] Multi-lang sites: Translateable navigation labels & site data Jan 17, 2020
@stale
Copy link

stale bot commented Apr 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Apr 17, 2020
@stale stale bot closed this as completed Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Development

No branches or pull requests

1 participant