Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for gzip compression #1305

Closed
jacopoch opened this issue Oct 27, 2013 · 6 comments · Fixed by #2687
Closed

Support for gzip compression #1305

jacopoch opened this issue Oct 27, 2013 · 6 comments · Fixed by #2687

Comments

@jacopoch
Copy link

This is nowhere urgent, but it would be cool to enable gzip compression to serve the assets of Ghost.

I am not super familiar with the codebase yet, but it seems you are using express. If so, then you could use its compress method as part of the configuration.

http://expressjs.com/api.html#compress

@halfdan
Copy link
Contributor

halfdan commented Oct 27, 2013

I think this should be handled by nginx (HttpGzipModule) or any other webserver that you put in front of Ghost.

@ErisDS
Copy link
Member

ErisDS commented Oct 28, 2013

We removed gzip compression as the express middleware had an issue with it. It's something we will look into adding again in future.

@ErisDS ErisDS closed this as completed Oct 28, 2013
@jacopoch
Copy link
Author

Thank you both, I will do some testing on my end, if I get it running with no hassle I will post a step-by-step for the community.

J

@pmsp
Copy link

pmsp commented Apr 15, 2014

please keep us updated on this since it would be a cool feature to have

@ErisDS
Copy link
Member

ErisDS commented May 4, 2014

I think it would be good to look at reenabling the express middleware for this, perhaps as an option which is enabled by default but can be disabled via config?

@shindakun
Copy link
Contributor

@ErisDS I had added gzip to my production install, just needed to make it configurable. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants