Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments don't play well with theme toggles #21103

Open
1 task done
cathysarisky opened this issue Sep 24, 2024 · 4 comments
Open
1 task done

Comments don't play well with theme toggles #21103

cathysarisky opened this issue Sep 24, 2024 · 4 comments
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@cathysarisky
Copy link
Contributor

Issue Summary

(This report references comments-ui version 0.17)

The mode="auto" styling works great -- it's awesome that themes that are running in dark mode automagically get dark mode for comments too. HOWEVER (yeah, there's always a however), themes with a toggle to let the user choose between dark/light cause the auto mode to break, as the comments iframe does not adjust colors when the theme does.

Theme creators could work around this by providing a background behind the comments that doesn't change when the slider is toggled after the page load, but that's going to be a pretty ugly hack and means that the comments are going to look weirdly wrong after the toggle button is flipped on that page.

Is there a way to make comments-ui detect that the color of the container has changed?

Steps to Reproduce

Quick way to fake switching modes: Add (or remove) "class='dark-mode'" to the html tag in casper.

Ghost Version

5.92

Node.js Version

18

How did you install Ghost?

WSL2/using Ghost-cli

Database type

MySQL 8

Browser & OS version

chrome/ Windows 10

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 24, 2024
@linear linear bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Sep 25, 2024
@Priyanshu-su30
Copy link

Assign me this I will work on it

@omchaudhary007
Copy link

I would like to resolve this.

@omchaudhary007
Copy link

/assign

@reallywasi
Copy link

I'd like to work on this.

@ErisDS ErisDS added the needs:triage [triage] this needs to be triaged by the Ghost team label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage [triage] this needs to be triaged by the Ghost team
Projects
None yet
Development

No branches or pull requests

5 participants