Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cannot copy text from preview pane #4028

Closed
Bilge opened this issue Sep 13, 2014 · 7 comments
Closed

Bug: Cannot copy text from preview pane #4028

Bilge opened this issue Sep 13, 2014 · 7 comments

Comments

@Bilge
Copy link

Bilge commented Sep 13, 2014

Issue Summary

Text cannot be copied from the post preview pane.

Steps to Reproduce

  1. Try to copy text from post preview pane.
  2. ...
  3. Cry.

This is a bug because text cannot be selected in the post preview pane.

Technical details

  • Ghost Version: 0.5.1
  • Client OS: Windows 7
  • Server OS: Ubuntu 14.10
  • Node Version: v0.10.31
  • Browser: Firefox 32
  • Database: SQLite
@ErisDS
Copy link
Member

ErisDS commented Sep 15, 2014

Hi @Bilge,

This is not a bug, the preview pane has deliberately had the ability to select text removed because it resulted in several usability issues with people interacting with the preview as though it was the editor.

Any interaction with text should be done with the editor pane. The left hand pane has a feature that allows you to copy HTML rather than the text as well.

Closing this against #1294 because we can review it when we do the editor overhaul.

@ErisDS ErisDS closed this as completed Sep 15, 2014
@Bilge
Copy link
Author

Bilge commented Sep 15, 2014

The left-hand pane does not have a feature to copy just text, as it appears in the preview, without any markup. Disabling text selection is the real usability issue here. You should not be disabling standard browser features because some people are, themselves, too disabled to figure out which of two panes is the one used for editing.

I urge you to reopen this issue and revise your decision in favour of allowing text selection in all parts of the application.

@novaugust
Copy link
Contributor

@Bilge: that's something we absolutely plan to do, but it won't be possible until we move towards a rewrite of the entire editor component. Until then, we close these "blocked" issues to keep our gh issues pared down. When we do start work on the editor, issues like this will be flagged and revisited

@Bilge
Copy link
Author

Bilge commented Sep 15, 2014

@novaugust I'd like to believe you but what you just said is diametrically opposed to what project lead @ErisDS just said. I'm also doubtful that ceasing to disable text selection would require an entire rewrite.

@ErisDS
Copy link
Member

ErisDS commented Sep 15, 2014

@Bilge I thought I said the exact same thing?

Closing this against #1294 because we can review it when we do the editor overhaul.

I've closed it against the issue where we're keeping track of all the small issues people raise with the editor. We're not fixing anything with the editor right now because we're about to launch into a big project to overhaul the editor and it would be a waste of effort.

Furthermore, we have tested the editor with and without the text-selection disabled and found that people find it easier to work with with it disabled. Regardless of what you think of our users, one person's opinion is not enough reason for us to change our approach.

@Bilge
Copy link
Author

Bilge commented Sep 15, 2014

You're right you have one person's opinion that you shouldn't disable text selection. That's one vote you can see and count right here before you. Meanwhile I've yet to see a single person who will put their name to the counter-vote that they are confused by being able to select text in a preview pane. Perhaps you can cite a source that proves there are people willing to claim this?

@jaswilli
Copy link
Contributor

@Bilge,

The tone of your responses in these issues you open up reads as very negative. Is there some reason why you are unable to conduct yourself in a respectful manner? If you plan on continuing to involve yourself in this project, I urge you to consider how your tone may come across to the people who have dedicated a large amount of time to this project.

Disabling text selection is the real usability issue here. You should not be disabling standard browser features because some people are, themselves, too disabled to figure out which of two panes is the one used for editing.

Ok. So you're putting that out there as the truth but without doing any work to back it up. Since you opened the issue and are requesting the change, the burden is on you to provide a compelling rationale to move forward.

And if you decide to do some research and provide some information, know that it will be appreciated and considered, but still likely not acted upon until the re-working of the editor is undertaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants