Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ember admin work with new access control #4182

Closed
sebgie opened this issue Sep 26, 2014 · 1 comment
Closed

Make Ember admin work with new access control #4182

sebgie opened this issue Sep 26, 2014 · 1 comment
Labels
affects:admin Anything relating to Ghost Admin

Comments

@sebgie
Copy link
Contributor

sebgie commented Sep 26, 2014

This belongs to the OAuth Epic: #4004 - please read this for the big picture of what this issue is for :)


The changes for making OAuth work for external clients are going to cause some updates to how we use OAuth with Ember admin. Ghost admin is a special application as it is the only application that is allowed to use username and password to login directly using the Resource Owner Password Credentials Grant (RFC 6749 - 4.3).

To keep the Ember admin working correctly, we will need to update the values for new fields created in #4174:

  • client_id: generated random number
  • redirection_uri: null
  • trusted_domains: null (if the client is of type Ghost Admin the url from config.js should be used)
  • logo: Ghost admin logo
  • status: enabled
  • type: Ghost Admin
  • description: tbd

In addition to that, the client_id needs to be available to the admin. This could be done similar to how we make fileStorage settings available. Authentication needs to be updated to use the new client_id as well.

@sebgie sebgie added affects:admin Anything relating to Ghost Admin OAuth labels Sep 26, 2014
@sebgie sebgie added this to the Future Backlog milestone Sep 26, 2014
@ErisDS ErisDS modified the milestone: Future Backlog Oct 9, 2015
@ErisDS
Copy link
Member

ErisDS commented Dec 7, 2015

This is already complete

@ErisDS ErisDS closed this as completed Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

No branches or pull requests

2 participants