Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn zip is not being used by the github action #103

Open
pradeep-dfi opened this issue Mar 13, 2024 · 1 comment
Open

yarn zip is not being used by the github action #103

pradeep-dfi opened this issue Mar 13, 2024 · 1 comment

Comments

@pradeep-dfi
Copy link

pradeep-dfi commented Mar 13, 2024

When I look at the source theme repo, it has yarn zip to generate the theme zip which uses gulp internally.

Considering that github actions does direct zipping, things seem to be not working as expected.

I have added a custom js file which is part of the zip prepared by the github actions, but it actually doesn't get used after getting uploaded to ghost. Ghost seems to generate a source.js file at some point which doesn't contain the custom js file that I added.

Is there a reason why yarn zip is not used to package the theme?

@russkiimike
Copy link

Hi, just wanted to piggy back , seems it doesn't build the theme css. Is that because of the yarn zip ? basically doesnt npm run zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants