Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version #1138

Closed
BridgeAR opened this issue Mar 25, 2019 · 10 comments
Closed

Release new version #1138

BridgeAR opened this issue Mar 25, 2019 · 10 comments

Comments

@BridgeAR
Copy link

The current sqlite3 version does not work together with Node.js v12.0.0-pre. This is already fixed on master but there's no new version released so far. I would like to point out that the official release date for Node.js v12 is very soon and it would be great to have a clean CITGM result on Node.js side.

Is there a plan to release a new version anytime soon?

@BridgeAR
Copy link
Author

BridgeAR commented Apr 5, 2019

Ping @kewde @gms1 @bruce-one @rzr

@rzr
Copy link
Contributor

rzr commented Apr 6, 2019

I can manually rebuild binaries for arm, arm64 x86 x64

@BridgeAR
Copy link
Author

@rzr sorry, I am not sure I can follow. The sqlite3 master branch has a fix that allows it to build against Node.js master (or at least it should) but that fix is not yet in an official sqlite3 release. CITGM will always use the latest official release and the last release still fails. We skip sqlite3 on that version because of the failure and it would be great to get it working again.

@johan13
Copy link

johan13 commented Apr 23, 2019

Node.js v12 was released today. Is there any news on when a version with node 12 support will be made available on npmjs?

As far as I understand, the compatibility issues have been fixed in master and we just need a new release, right?

@ForsakenHarmony
Copy link

Reported 29 days ago and no response 🙃

@kewde
Copy link
Collaborator

kewde commented Apr 26, 2019

Blocked till AppVeyor (CI) supports Node 12 (required for Windows binaries :/)

@BridgeAR
Copy link
Author

BridgeAR commented May 1, 2019

@kewde would it not be possible to already publish 4.0.7 with the current master branch (I did not check if there are new features or breaking changes, so I guess it's a patch release)? That way most people would already be able to use sqlite3, no matter if AppVeyor supports it or not. Or am I missing something?

@kewde
Copy link
Collaborator

kewde commented May 7, 2019

Node 12 has been merged to master, will do release very soon.

@rzr
Copy link
Contributor

rzr commented May 8, 2019

may this also help for ARM64:
#1147

@kewde
Copy link
Collaborator

kewde commented May 8, 2019

v4.0.7 has been released.

@kewde kewde closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants