Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove connection authentication #1556

Closed
holmesworcester opened this issue Jun 2, 2023 · 5 comments
Closed

Remove connection authentication #1556

holmesworcester opened this issue Jun 2, 2023 · 5 comments
Assignees
@Kacper-RF

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented Jun 2, 2023 •
edited
Loading

As part of #1340 we should remove connection authentication so that users can connect to the community's network immediately using one or more community onion addresses.
@holmesworcester holmesworcester converted this from a draft issue Jun 2, 2023
@holmesworcester holmesworcester moved this from Sprint to Next sprint in Quiet Jun 15, 2023
@vinkabuki
Copy link
Contributor

To be exact: community members libp2p addresses.

@vinkabuki vinkabuki moved this from Next sprint to Sprint in Quiet Jul 19, 2023
@Kacper-RF Kacper-RF self-assigned this Jul 27, 2023
@Kacper-RF Kacper-RF moved this from Next Sprint to In progress in Quiet Jul 27, 2023
@Kacper-RF Kacper-RF moved this from In progress to Waiting for review in Quiet Jul 28, 2023
@vinkabuki vinkabuki moved this from Waiting for review to Merged (develop) in Quiet Aug 29, 2023
@vinkabuki vinkabuki moved this from Merged (develop) to Ready for QA in Quiet Aug 29, 2023
@kingalg
Copy link
Collaborator

kingalg commented Sep 5, 2023

How can I test this and is there a visible impact for users?

@holmesworcester
Copy link
Contributor Author

The main thing is that when all these changes are done, a user should be able to join without the owner being online.

There might be other visible impacts but they're all secondary and might be hard to see.

@EmiM
Copy link
Contributor

EmiM commented Sep 5, 2023

Original PR: #1671

Fix for regression, probably introduced while resolving conflicts with develop: #1765

@kingalg
Copy link
Collaborator

kingalg commented Oct 23, 2023

Version: 2.0.1-alpha.7
mobile@2.0.0-alpha.21 (iOS 319)

Users can consistently join the app when the owner is offline.

@kingalg kingalg closed this as completed Oct 23, 2023
@kingalg kingalg moved this from Ready for QA to Done in Quiet Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kacper-RF Kacper-RF

Labels
None yet
Projects
Quiet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@holmesworcester @EmiM @vinkabuki @kingalg @Kacper-RF