Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep links doesn't work #1920

Closed
siepra opened this issue Oct 5, 2023 · 3 comments
Closed

Deep links doesn't work #1920

siepra opened this issue Oct 5, 2023 · 3 comments
Assignees
@siepra
Labels
bug Something isn't working mobile react-native

Comments

@siepra
Copy link
Contributor

siepra commented Oct 5, 2023 •
edited
Loading

I suspect it has something to do with store not being ready while trying to dispatch deepLink action. It's probably a race condition which can be fixed in the react-native layer.

It was probably introduced while making changes for handling lifecycle changes on iOS.
@siepra siepra added this to Quiet Oct 5, 2023
@siepra siepra converted this from a draft issue Oct 5, 2023
@siepra siepra added bug Something isn't working react-native labels Oct 5, 2023
@siepra siepra self-assigned this Oct 5, 2023
@holmesworcester holmesworcester moved this from Sprint to Backlog - Mobile in Quiet Oct 5, 2023
@holmesworcester
Copy link
Contributor

holmesworcester commented Oct 5, 2023 •
edited
Loading

Noting from the morning update that this impacts joining a community. Added to sprint since that seems like a blocker

@holmesworcester holmesworcester moved this from Backlog - Mobile to Sprint in Quiet Oct 5, 2023
@siepra siepra moved this from Sprint to In progress in Quiet Oct 9, 2023
@siepra
Copy link
Contributor Author

siepra commented Oct 9, 2023 •
edited
Loading

PR #1935

@siepra siepra moved this from In progress to Waiting for review in Quiet Oct 9, 2023
@siepra siepra moved this from Waiting for review to (Mobile) Ready for QA in Quiet Oct 9, 2023
@siepra siepra added the mobile label Jan 11, 2024
@kingalg
Copy link
Collaborator

kingalg commented Feb 1, 2024

mobile@2.1.1-alpha.0 | iOS 350

Fixed

@kingalg kingalg closed this as completed Feb 1, 2024
@kingalg kingalg moved this from (Mobile) Ready for QA to Done in Quiet Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siepra siepra

Labels
bug Something isn't working mobile react-native
Projects
Quiet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@holmesworcester @siepra @kingalg