Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minADE is not right #43

Open
shuishenbushui opened this issue Apr 7, 2023 · 8 comments
Open

minADE is not right #43

shuishenbushui opened this issue Apr 7, 2023 · 8 comments

Comments

@shuishenbushui
Copy link

when I trained the Set Predictor, eval results are as follows:

other_errors {'stage_one_k': 3.0803698258030754, 'stage_one_recall': 0.9638398086076706, 'set_MR_pred': 0.0738903979863932, 'set_minFDE_pred': 1.3842987156892936}
{'minADE': 14.246385467933312, 'minFDE': 1.3842987156892916, 'MR': 0.0738903979863932}
ADE 14.316873007381048
DE@1 9.875993647573898
DE@2 19.429086244927365
DE@3 3.496420582410066

the minADE is absolutely wrong. I visualize the pred trajs, they are also not right, I think the complete traj module is not trained sufficient, but I trained the model follow your instructions, so where exactly is the problem?

@shuishenbushui
Copy link
Author

Decoder.py 174, why you add a 'pass', skip the loss of pred trajs ?causing the complete traj module not trained.

@GentleSmile
Copy link
Member

The 'pass' does not take any effect here. What is the value of 'complete_traj' in args.other_params, is it True?

@shuishenbushui
Copy link
Author

Sorry,I made a mistake of 'pass'. But 'complete_traj' is indeed True. Can you give me a trained weight?

@shuishenbushui
Copy link
Author

These are my parameters, Can you find what is wrong?

--argoverse
--future_frame_num
30
--do_train
--data_dir
train/data/
--output_dir
models_complete_traj
--model_recover_path=models.densetnt.set_predict.2/model_save/model.16.bin
--hidden_size
128
--train_batch_size
64
--use_map
--core_num
16
--use_centerline
--distributed_training
1
--other_params
semantic_lane
direction
l1_loss
goals_2D
enhance_global_graph
subdivide
goal_scoring
laneGCN
point_sub_graph
lane_scoring
complete_traj
set_predict=6
set_predict-6
data_ratio_per_epoch=0.4
set_predict-topk=0
set_predict-one_encoder
set_predict-MRratio=1.0
set_predict-train_recover=models.densetnt.set_predict.2/model_save/model.16.bin
--reuse_temp_file

@GentleSmile
Copy link
Member

It seems that model_recover_path does not appear in the README

@shuishenbushui
Copy link
Author

It doesn‘t matter,if I don't set model_recover_path, it will go to ./tmp to search the weight file. Can you give me a wechat number for deeper communication for details?

@GentleSmile
Copy link
Member

What is your evaluation command? During evaluation, you should set model_recover_path to the correct ${OUTPUT_DIR}/model_save/model.16.bin.

@shuishenbushui
Copy link
Author

Thank u, I knew my problem. model_recover_path should be set to weights of Set Predictor training, but set_predict-train_recover set should be set to weights of first training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants