Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is that a typo in base.py? #58

Open
chivas1000 opened this issue Nov 6, 2024 · 0 comments
Open

is that a typo in base.py? #58

chivas1000 opened this issue Nov 6, 2024 · 0 comments

Comments

@chivas1000
Copy link

chivas1000 commented Nov 6, 2024

I have found in model/base.py
the direction prediction are using up1_embedding:
if self.direction_pred: x_direction = self.up1_embedded(x2, x1) x_direction = self.up2_direction(x_direction)

x_direction = self.up1_embedded(x2, x1)

why using up_1embedded blocks instead of using up1_direction as the up1_direction is already defined.
and will the weights of up1_embedded blocks are affected by the direction prediction?

@chivas1000 chivas1000 reopened this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant