-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about Closed Simulation. #193
Comments
@Yyb-XJTU 您好!你所### 使用的数据集是直接从Hugging Face Dataset上面下载的吗?能分享一下data_path,map_path的路径吗?我运行这个命令
有下面的问题 Folder where all results are stored: testing_log/closed_loop_nonreactive_agents/str_closed_planner/TestHard14_MixtralM_CKS_SepLoss_AugCur50Pct_PastProj_S6_bf16_Jun28_ckpt150k
非常感谢! |
@Yyb-XJTU Thank you for pointing out the mistakes. Actually, the |
@JohnZhan2023 Thank you for your reply. When I run "run_simulation_closed.py", I find that the result is very close to the result in your paper. However, this file runs "str_closed_planner" (Is this the Planner used in the paper?), and the main body of this planner is "PDM Planner". How does this reflect the role of "str"? |
@Yyb-XJTU Actually, the str_closed_planner is the postprocessed version of the str planner and it will use pdm's strategy to refine the trajectory given by str. And the pure str (run_simulation.py) will get a higher score when the number of parameters come to 800m as more parameters bring more generalization ability. 800m str will be much better than the 100m. For more details about the str's role, you can resort to the paper. |
Thank you for your reply. I have carefully read your paper and noticed that there doesn’t seem to be a detailed explanation of the post-processing steps. Also, in the comparative experiments, it’s not entirely clear which results correspond to pure STR outputs and which are post-processed. If possible, could you please share more details about these experimental results? In addition, I ran the pure str (100m) alone, and the closed-loop score was only over 30. Is this too low? |
Actually, in the paper, we don't show the scores of pure STR outputs. All the results are based on the post processing of the PDM. Current simulation pipelines may not support pure STR simulation. The 30+ score is not reasonable apparently and there must be mismatch in the simulation pipeline. You may need to revise the planner and if you are interested in the score of pure STR, you can revise the planner and push it to a new branch, and we can help you debug it. |
We appreciate your interest in our work. The current code base (the planner and model part) was not tested and debuged for "pure STR outputs" against the closed-loop simulation testings without "post-processing steps". So in short, no results can be confirmed or verified, but 30 is way too low to make sense. (even lower than early UrbanDrivers). It is not clear how you tested. As @JohnZhan2023 mentioned, there might be some mismatches here and there (such as a frequency downsampling on the labels we did for efficiency). We kindly suggest:
Sharing your codes and detailed results will be helpful and is always welcome. |
When I try to Simulation with the below script:
I found that "run_nuplan_simulation.py" does not support the above argument, but "run_simulation.py" does. Is this a mistake in the README description?
The text was updated successfully, but these errors were encountered: