Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify execution order in FromFunctionThrustEngineSettings #170

Closed
FrankHogervorst opened this issue Mar 24, 2017 · 5 comments
Closed

Verify execution order in FromFunctionThrustEngineSettings #170

FrankHogervorst opened this issue Mar 24, 2017 · 5 comments

Comments

@FrankHogervorst
Copy link
Contributor

Verify whether the update function is called before the other functions in FromFunctionThrustEngineSettings.

@DominicDirkx
Copy link
Member

What exactly was this issue about again? I remember I asked you to open it to remind to have a look at it, but now I forgot the details of it....

@FrankHogervorst
Copy link
Contributor Author

Hmm, this is a while ago. This issue could be the result of a question I had about my guidance class. This class contains one function which updates the attributes (thrustMagnitude and bodyFixedThrustDirection) and has get functions to obtain these specific parameters.

At the time I was wondering how I could call the update function only once per integration step and use the get functions for the ThrustMagnitudeFunction_ and bodyFixedThrustDirection_ inside FromFunctionThrustEngineSettings. Now I call updateGuidance() in the getBodyFixedThrustDirection() method before the return statement.

@DominicDirkx
Copy link
Member

Which classes are you referring to exactly?

@FrankHogervorst
Copy link
Contributor Author

The updatefunction in the guidance class is located in thrustParameterisation.

The get functions for bodyFixedThrustDirection and thrustMagnitude.

If I remember correctly you said it wasnt required to place the updateguidance() function inside the getBodyFixedThrustDirection due to the execution order in FromFunctionThrustEngineSettings. But you had to verify that.

An example of its usage can be found here.

@DominicDirkx
Copy link
Member

Hi Frank,

I didn't realise that all referenced your own code. As this is specific to what you have written, I'm closing this issue. To be able to properly understand your question, you should walk me through your code some time. If you want, you can reopen this issue on your own Github Tudat, which is the correct place for it, I think.

Dominic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants