Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.7.10] Request: Locus compatibility with Gadomany's Condenser #67

Open
LordPinkerton opened this issue Feb 21, 2018 · 3 comments
Open

Comments

@LordPinkerton
Copy link

Would it be possible to add compatibility for the Essentia Locus to read and interact with Gadomany's Essentia Condenser? I'm uncertain how the condenser stores the information other than it seems similar to the Essentia Reservoir, which the Locus can read. I have tried using the Crystalline Eye on every block of the condenser, even all three of them simultaneously, without it being able to read it. I can only assume this is a compatibility issue at this point.

@Tuhljin
Copy link
Owner

Tuhljin commented Feb 21, 2018

Automagy attempts to interact with other mods' essentia sources in the ways which are standard for Thaumcraft. It also includes a basic API that allows integration when that way is insufficient. In some cases, I've done the integration myself or even made special hardcoded integrations, but it would be nice if other mods used the API since that's what it's there for.

I'm not sure how Gadomancy's essentia condenser is coded, but most likely, the simplest solution would be for it to implement my IEssentiaLocusReadable interface -- and, ideally, IAspectContainerWithMax as well. Those interfaces can be found here.

If Gadomancy isn't going to be so updated and there is enough demand, I will consider doing something on my end -- but I've been meaning to update Automagy for ages and haven't found the time to do so yet, so don't hold your breath.

@LordPinkerton
Copy link
Author

Thank you for taking the time to respond to this. I doubt makeoo will update Gadomancy, as he has been inactive since it's last release years ago. I don't know how much demand there is going to be for this particular issue other than a few others I've seen post on forums or on Gadomancy's issue tracker. Anything you could do would be greatly appreciated, but understandable if you never get around to it. If not, I might just try my own hand at making some sort of go between solution. But, I'd still like to take the time regardless to thank you for what I consider the absolute best addition to Thaumcraft 4.

@Tuhljin
Copy link
Owner

Tuhljin commented Feb 22, 2018

Thanks for the kind words! :)

I'd certainly like to take a look at this for you. If only I weren't buried under so many more urgent projects right now.... I'll put it on my list, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants