Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to validate profile values #25

Merged

Conversation

datejada
Copy link
Member

Pull request details

Describe the changes made in this pull request

A new function to validate the profile inputs before performing the fitting procedure.

List of related issues or pull requests

Closes #22

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • [NA] The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c809bca) 100.00% compared to head (9e8b290) 100.00%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           13        28   +15     
=========================================
+ Hits            13        28   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions.

src/model.jl Outdated Show resolved Hide resolved
src/model.jl Outdated Show resolved Hide resolved
Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelsiqueira abelsiqueira merged commit ef31947 into TulipaEnergy:main Nov 21, 2023
12 checks passed
@datejada datejada deleted the 22-create-validation-function branch November 21, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a validation function for the input data
2 participants