Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 4 support #38

Closed
tjunnone opened this issue Mar 7, 2018 · 1 comment · Fixed by #39
Closed

Webpack 4 support #38

tjunnone opened this issue Mar 7, 2018 · 1 comment · Fixed by #39
Labels
enhancement

Comments

@tjunnone
Copy link
Contributor

tjunnone commented Mar 7, 2018

When webpack-notifier is used with webpack 4 (tested with 4.1.0), a deprecation warning is issued:

(node:23649) DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead
@tjunnone tjunnone mentioned this issue Mar 8, 2018
Merged
@IgorKurkov
Copy link

node --trace-deprecation ./node_modules/webpack/bin/webpack --bail --env dist -p on windows helps to figure out that this plugin use tapable as deprecated module.
thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for webpack 4 plugin system tjunnone/webpack-notifier
3 participants
@Turbo87 @tjunnone @IgorKurkov