Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script.jl #78

Closed
wants to merge 1 commit into from
Closed

Conversation

mattiasvillani
Copy link
Contributor

Fixed some minor typos in the text, and one typo in the code.

Fixed some typos.
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d785ce5) 96.31% compared to head (74520d9) 96.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files           6        7    +1     
  Lines         380      381    +1     
=======================================
+ Hits          366      367    +1     
  Misses         14       14           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FredericWantiez
Copy link
Member

Nice catch, thanks for the fix

@mattiasvillani
Copy link
Contributor Author

mattiasvillani commented Sep 4, 2023

I just opened another PR #79 , which includes the changes in this one, but also adds PGAS sampling to fix #77.
I leave this open in case my other PR gets rejected.

@FredericWantiez
Copy link
Member

Yes, let's just do one for the two examples. We can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants